dependabot: auto-merge requires on pull_request types - #43017
Conversation
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Pull request overview
This pull request proposes changing the trigger event for the Dependabot auto-merge workflow from pull_request to pull_request_target with specific activity types. The PR description claims this change is needed to fix authentication issues (401 errors due to insufficient scope).
Changes:
- Modified the workflow trigger from
on: pull_requesttoon: pull_request_targetwith types[opened, reopened, synchronize]
Auto-merge appears to function correctly with `pull_request` with types, allowing it to authenticate and operate within the context of the target repository. Without this, a 401 error is returned due to insufficient scope. Signed-off-by: Seena Fallah <seenafallah@gmail.com>
|
@clwluvw I'll have to check in about this one since it's code security and altering code. Have to get extra approval for that. |
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
|
Hi @clwluvw, please accept my apologies for the late reply I've investigated this, but I'm unable to produce it, and: Should be functionally equivalent to As such, I think something else may have happened here—possibly a bug—and if this is still relevant, I'd suggest one of three things:
Once again, please accept my apologies for the lateness, but under the circumstances I'm going to go ahead and close this out. Thank you for your interest in the GItHub docs |
Why:
Auto-merge appears to function correctly with
pull_requestwith types, allowing it to authenticate and operate within the context of the target repository. Without this, a 401 error is returned due to insufficient scope.Check off the following: